Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ActionsColumn): removed tooltip prop #535

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

thatblindgeye
Copy link
Collaborator

Closes #534

ruleTester.run("tableActionsColumn-removed-tooltipProp", rule, {
valid: [
{
code: `<ActionsColumn items={[{tooltipProps: {content: "test"}}]} />`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: shouldn't this valid test have the patternfly import?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops

Updated

Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wise-king-sullyman wise-king-sullyman merged commit 8d19341 into patternfly:main Jul 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: removed tooltip prop on ActionsColumn
2 participants